[WIP][SYCL] Fix kernel name mangling for CUDA/HIP with Microsoft ABI host #20973
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
force-pushed
the
CMPLRLLVM-69642-sycl-cuda-kernel-mangling
branch
from
32c9f70 to
55c155c
Compare
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
force-pushed
the
CMPLRLLVM-69642-sycl-cuda-kernel-mangling
branch
from
55c155c to
307759c
Compare
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
force-pushed
the
CMPLRLLVM-69642-sycl-cuda-kernel-mangling
branch
from
451b21b to
7445a0a
Compare
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
force-pushed
the
CMPLRLLVM-69642-sycl-cuda-kernel-mangling
branch
from
520457d to
ede11a7
Compare
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
In SYCL offload compilation, when the host uses Microsoft ABI and the device uses Itanium ABI (e.g., Windows host with CUDA device), kernel names were mangled differently between host and device code, causing runtime errors when the host tried to find kernels by name. This fix ensures consistent mangling by using the device's mangling context on the host side when compiling for cross-ABI scenarios. This is detected by checking if the host target uses Microsoft ABI while the auxiliary (device) target uses Itanium ABI. The change is minimal and only affects the specific cross-ABI case, preserving existing behavior for same-ABI compilations.
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL kernel names are generated during template instantiation using MangleContext, which produces different encodings based on target ABI. When host compilation uses Microsoft ABI and device compilation targets Itanium ABI (CUDA/HIP), this caused runtime kernel lookup failures:
No kernel named _ZTSZZ21performIncrementationENK... was found
The issue occurred because Sema::PerformPendingInstantiations() used ASTContext::createMangleContext(), which creates an ABI-specific context for the primary target. In cross-ABI scenarios (Microsoft host + Itanium device), this produced inconsistent names between host and device.
Solution:
This ensures identical kernel names across compilations, allowing runtime lookup to succeed.